Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224263002: Remove 'defer' KeyWord from preserveAspectRatio (Closed)

Created:
5 years, 5 months ago by Shanmuga Pandi
Modified:
5 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove 'defer' KeyWord from preserveAspectRatio With this change, encountering 'defer' keyword will throw parse error. BUG=507629 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198601

Patch Set 1 #

Total comments: 3

Patch Set 2 : Align with review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -72 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/dom/preserve-aspect-ratio-parser.html View 1 chunk +27 lines, -27 lines 0 comments Download
M LayoutTests/svg/dom/preserve-aspect-ratio-parser-expected.txt View 4 chunks +61 lines, -33 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Shanmuga Pandi
Please review it. Thanks
5 years, 5 months ago (2015-07-09 11:01:40 UTC) #2
fs
lgtm https://codereview.chromium.org/1224263002/diff/1/LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt File LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt (right): https://codereview.chromium.org/1224263002/diff/1/LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt#newcode1 LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt:1: CONSOLE ERROR: line 20: Error: Invalid value for ...
5 years, 5 months ago (2015-07-09 11:24:13 UTC) #3
Shanmuga Pandi
https://codereview.chromium.org/1224263002/diff/1/LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt File LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt (right): https://codereview.chromium.org/1224263002/diff/1/LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt#newcode6 LayoutTests/platform/win/svg/custom/preserve-aspect-ratio-syntax-expected.txt:6: CONSOLE ERROR: line 39: Error: Invalid value for <svg> ...
5 years, 5 months ago (2015-07-09 11:47:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224263002/20001
5 years, 5 months ago (2015-07-09 11:56:21 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 13:18:34 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198601

Powered by Google App Engine
This is Rietveld 408576698