Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/svg/dom/preserve-aspect-ratio-parser-expected.txt

Issue 1224263002: Remove 'defer' KeyWord from preserveAspectRatio (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Align with review comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/preserve-aspect-ratio-parser.html ('k') | Source/core/svg/SVGPreserveAspectRatio.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/dom/preserve-aspect-ratio-parser-expected.txt
diff --git a/LayoutTests/svg/dom/preserve-aspect-ratio-parser-expected.txt b/LayoutTests/svg/dom/preserve-aspect-ratio-parser-expected.txt
index 8cf37868bed87601008d19c985d33447b2b58fcf..da0961498afbb3fafa2c0ede901d57bd318ed11f 100644
--- a/LayoutTests/svg/dom/preserve-aspect-ratio-parser-expected.txt
+++ b/LayoutTests/svg/dom/preserve-aspect-ratio-parser-expected.txt
@@ -1,4 +1,32 @@
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMin"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMin"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMin"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMid"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMid"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMid"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMax"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMax"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMax"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMin meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMin meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMin meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMid meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMid meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMid meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMax meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMax meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMax meet"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMin slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMin slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMin slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMid slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMid slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMid slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMinYMax slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMidYMax slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer xMaxYMax slice"
CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="slice"
+CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="defer"
CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="meet"
CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="slice"
CONSOLE ERROR: Error: Invalid value for <image> attribute preserveAspectRatio="xminymin"
@@ -124,19 +152,19 @@ PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SV
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
Test string: 'defer xMinYMin'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMIN
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMin'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMIN
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMin'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMinYMid'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMID
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMid'
@@ -144,35 +172,35 @@ PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SV
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMid'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMID
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMinYMax'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMAX
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMax'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMAX
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMax'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMAX
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMinYMin meet'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMIN
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMin meet'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMIN
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMin meet'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMinYMid meet'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMID
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMid meet'
@@ -180,56 +208,56 @@ PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SV
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMid meet'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMID
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMinYMax meet'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMAX
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMax meet'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMAX
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMax meet'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMAX
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMinYMin slice'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMIN
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMin slice'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMIN
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMin slice'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMinYMid slice'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMID
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMid slice'
PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMid slice'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMID
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMinYMax slice'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMAX
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMidYMax slice'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMAX
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Test string: 'defer xMaxYMax slice'
-PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMAX
-PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_SLICE
+PASS imageElement.preserveAspectRatio.baseVal.align is SVGPreserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMID
+PASS imageElement.preserveAspectRatio.baseVal.meetOrSlice is SVGPreserveAspectRatio.SVG_MEETORSLICE_MEET
Tests for some whitespace cases.
« no previous file with comments | « LayoutTests/svg/dom/preserve-aspect-ratio-parser.html ('k') | Source/core/svg/SVGPreserveAspectRatio.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698