Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224223003: Fold CSSParser::colorFromRGBColorString into only user (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
pdr., Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fold CSSParser::colorFromRGBColorString into only user Said method is very special flower, used by the SMIL animation code to put color values into SVGColorProperty. Since it's essentially a one-off (and supporting a deprecated class part of a deprecated whole) fold it into it's only user and rid the CSSParser of this burden, ehm, flower. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M Source/core/css/parser/CSSParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.h View 2 chunks +3 lines, -7 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +10 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 5 months ago (2015-07-09 14:49:55 UTC) #2
pdr.
Flower power! LGTM
5 years, 5 months ago (2015-07-09 18:34:33 UTC) #3
fs
On 2015/07/09 18:34:33, pdr wrote: > Flower power! > > LGTM Peace man! Groovy!
5 years, 5 months ago (2015-07-10 08:05:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224223003/1
5 years, 5 months ago (2015-07-10 08:05:20 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 08:09:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198672

Powered by Google App Engine
This is Rietveld 408576698