Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: Source/core/svg/SVGAnimatedColor.h

Issue 1224223003: Fold CSSParser::colorFromRGBColorString into only user (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/CSSParser.cpp ('k') | Source/core/svg/SVGAnimatedColor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimatedColor.h
diff --git a/Source/core/svg/SVGAnimatedColor.h b/Source/core/svg/SVGAnimatedColor.h
index 3dfd400b8fe6659e0deaa649a3189ae184309551..212ba5c8efc7c5f3935f898eefd9dd20710cfdda 100644
--- a/Source/core/svg/SVGAnimatedColor.h
+++ b/Source/core/svg/SVGAnimatedColor.h
@@ -42,9 +42,9 @@ class SVGAnimationElement;
// FIXME: WebAnimations: Replacable with AnimatableColor once SMIL animations are implemented in WebAnimations.
class SVGColorProperty final : public SVGPropertyBase {
public:
- static PassRefPtrWillBeRawPtr<SVGColorProperty> create(StyleColor styleColor)
+ static PassRefPtrWillBeRawPtr<SVGColorProperty> create(const String& colorString)
{
- return adoptRefWillBeNoop(new SVGColorProperty(styleColor));
+ return adoptRefWillBeNoop(new SVGColorProperty(colorString));
}
PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const String&) const override;
@@ -57,11 +57,7 @@ public:
static AnimatedPropertyType classType() { return AnimatedColor; }
private:
- explicit SVGColorProperty(StyleColor styleColor)
- : SVGPropertyBase(classType())
- , m_styleColor(styleColor)
- {
- }
+ explicit SVGColorProperty(const String&);
StyleColor m_styleColor;
};
« no previous file with comments | « Source/core/css/parser/CSSParser.cpp ('k') | Source/core/svg/SVGAnimatedColor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698