Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224083008: ServiceWorker: Change a target url to open (Closed)

Created:
5 years, 5 months ago by nhiroki
Modified:
5 years, 5 months ago
Reviewers:
falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Change a target url to open Our test uses a real domain and opens a page on that. The origin should be replaced with a dummy defined by get-host-info.js. BUG=437151 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nhiroki
PTAL, thanks!
5 years, 5 months ago (2015-07-10 07:49:37 UTC) #2
falken
looks good, but CL description should say "why" and can you track down the BUG= ...
5 years, 5 months ago (2015-07-10 07:51:32 UTC) #3
nhiroki
Thanks, updated!
5 years, 5 months ago (2015-07-10 08:34:14 UTC) #4
falken
lgtm, thanks!
5 years, 5 months ago (2015-07-10 08:35:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224083008/1
5 years, 5 months ago (2015-07-10 08:39:53 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 10:05:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198676

Powered by Google App Engine
This is Rietveld 408576698