Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2847)

Unified Diff: chrome/chrome_installer_util.gypi

Issue 1223953003: Introduce UpdateActiveSetupVersionWorkItem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a1_active_setup_onosup_addCB_API
Patch Set: Do not support negative values (operate on unsigned ints) Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_installer_util.gypi
diff --git a/chrome/chrome_installer_util.gypi b/chrome/chrome_installer_util.gypi
index 334e427b1d170d0f1c8b0a3756caaf0b8c76c817..cb8f1d573c39f5b2e1d6a09a662072e25f0f3c9b 100644
--- a/chrome/chrome_installer_util.gypi
+++ b/chrome/chrome_installer_util.gypi
@@ -88,6 +88,8 @@
'installer/util/self_reg_work_item.h',
'installer/util/set_reg_value_work_item.cc',
'installer/util/set_reg_value_work_item.h',
+ 'installer/util/update_active_setup_version_work_item.cc',
grt (UTC plus 2) 2015/07/09 14:23:53 since this is only used by setup.exe, please move
gab 2015/07/09 20:36:37 I debated this, but this is true of all WorkItems
grt (UTC plus 2) 2015/07/10 15:37:27 Some of them are used by chrome.exe (shell_util.cc
gab 2015/07/13 16:37:37 Another bad trend this forces me to follow now is
+ 'installer/util/update_active_setup_version_work_item.h',
'installer/util/updating_app_registration_data.cc',
'installer/util/updating_app_registration_data.h',
'installer/util/util_constants.cc',

Powered by Google App Engine
This is Rietveld 408576698