Introduce UpdateActiveSetupVersionWorkItem

chrome/chrome_installer_util.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'target_defaults': {
     'variables': {
       'installer_util_target': 0,
     },
     'target_conditions': [
@@ skipping 70 matching lines @@
           'installer/util/move_tree_work_item.cc',
           'installer/util/move_tree_work_item.h',
           'installer/util/non_updating_app_registration_data.cc',
           'installer/util/non_updating_app_registration_data.h',
           'installer/util/registry_key_backup.cc',
           'installer/util/registry_key_backup.h',
           'installer/util/self_reg_work_item.cc',
           'installer/util/self_reg_work_item.h',
           'installer/util/set_reg_value_work_item.cc',
           'installer/util/set_reg_value_work_item.h',
+          'installer/util/update_active_setup_version_work_item.cc',

[grt (UTC plus 2), 2015/07/09 14:23:53]

since this is only used by setup.exe, please move it into installer/setup. it's
nice that your design allows for this. yay!

[gab, 2015/07/09 20:36:37]

I debated this, but this is true of all WorkItems AFAICT, a nice follow-up
cleanup, but I don't think this CL should introduce an outlier in the mean time.

[grt (UTC plus 2), 2015/07/10 15:37:27]

Some of them are used by chrome.exe (shell_util.cc uses them for the registry
stuff), so they can't all be moved into setup.
I don't see this as a compelling reason to follow a bad trend. In the worst
case, chrome.exe will be bloated with dead code leading to larger downloads and
more bits in the binary.

[gab, 2015/07/13 16:37:37]

Another bad trend this forces me to follow now is the setup_unittests target
actually doesn't depend on "setup" and redeclares inclusions twice:
"""
  # TODO(robertshield): Move the items marked with "Move to lib"
  # below into a separate lib and then link both setup.exe and
  # setup_unittests.exe against that.
"""

But oh well, I don't think this matters enough to block this much more important
CL.

(also, since I want to merge this I'm leery of not having the tests on the
waterfall NOW, but I'll run them locally and hope for the best..).

+          'installer/util/update_active_setup_version_work_item.h',
           'installer/util/updating_app_registration_data.cc',
           'installer/util/updating_app_registration_data.h',
           'installer/util/util_constants.cc',
           'installer/util/util_constants.h',
           'installer/util/wmi.cc',
           'installer/util/wmi.h',
           'installer/util/work_item.cc',
           'installer/util/work_item.h',
           'installer/util/work_item_list.cc',
           'installer/util/work_item_list.h',
@@ skipping 123 matching lines @@
           ],
           'include_dirs': [
             '<(DEPTH)',
           ],
         }
       ],
     }],
 
   ],
 }