Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

Issue 1223813006: dart2js cps: Direct access on JS arrays. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update unit tests and remove unused functions Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart
diff --git a/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart b/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart
index a6acceb4ca7e5e2b9977002194e75ffd7c59a4a8..1820f1d8af16a6a235c748810d60483ed345a350 100644
--- a/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart
+++ b/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart
@@ -315,6 +315,24 @@ class PullIntoInitializers extends RecursiveTransformer
return node;
}
+ Expression visitGetLength(GetLength node) {
+ super.visitGetLength(node);
+ ++impureCounter;
+ return node;
+ }
+
+ Expression visitGetIndex(GetIndex node) {
+ super.visitGetIndex(node);
+ ++impureCounter;
+ return node;
+ }
+
+ Expression visitSetIndex(SetIndex node) {
+ super.visitSetIndex(node);
+ ++impureCounter;
+ return node;
+ }
+
void visitInnerFunction(FunctionDefinition node) {
new PullIntoInitializers().rewrite(node);
}

Powered by Google App Engine
This is Rietveld 408576698