Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1223813006: dart2js cps: Direct access on JS arrays. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update unit tests and remove unused functions Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 14471733eaaf67c9c9dcfc02a835cc1248f3b5dd..31d030ff622970a9e12718834346d86cb264e5ff 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -664,6 +664,26 @@ class CodeGenerator extends tree_ir.StatementVisitor
return new js.Assignment(field, value);
}
+ @override
+ js.Expression visitGetLength(tree_ir.GetLength node) {
+ return new js.PropertyAccess.field(visitExpression(node.object), 'length');
+ }
+
+ @override
+ js.Expression visitGetIndex(tree_ir.GetIndex node) {
+ return new js.PropertyAccess(
+ visitExpression(node.object),
+ visitExpression(node.index));
+ }
+
+ @override
+ js.Expression visitSetIndex(tree_ir.SetIndex node) {
+ return js.js('#[#] = #',
+ [visitExpression(node.object),
+ visitExpression(node.index),
+ visitExpression(node.value)]);
+ }
+
js.Expression buildStaticHelperInvocation(FunctionElement helper,
List<js.Expression> arguments) {
registry.registerStaticUse(helper);
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698