Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 122373003: Add the gears.js demo and all the code changes needed to get it working, including (Closed)

Created:
6 years, 11 months ago by jcgregorio
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@gl
Visibility:
Public.

Description

Add the gears.js demo and all the code changes needed to get it working, including implementing both fill and stroke style. Also add the HTML and JS files to compare with browser performance. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12946

Patch Set 1 #

Patch Set 2 : add in compare. #

Patch Set 3 : again #

Patch Set 4 : 80 cols #

Patch Set 5 : 80 cols #

Total comments: 2

Patch Set 6 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -54 lines) Patch
M experimental/SkV8Example/JsContext.h View 1 2 3 4 5 3 chunks +24 lines, -13 lines 0 comments Download
M experimental/SkV8Example/JsContext.cpp View 1 7 chunks +78 lines, -39 lines 0 comments Download
experimental/SkV8Example/compare/gears.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
experimental/SkV8Example/compare/gears.js View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download
A experimental/SkV8Example/gears.js View 1 1 chunk +88 lines, -0 lines 0 comments Download
M experimental/SkV8Example/path.js View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jcgregorio
6 years, 11 months ago (2014-01-07 18:26:00 UTC) #1
robertphillips
Why do we have two copies of the .js file? Is there any copyright stuff ...
6 years, 11 months ago (2014-01-07 18:36:14 UTC) #2
robertphillips
Oh and lgtm
6 years, 11 months ago (2014-01-07 18:39:57 UTC) #3
jcgregorio
https://codereview.chromium.org/122373003/diff/80001/experimental/SkV8Example/JsContext.h File experimental/SkV8Example/JsContext.h (right): https://codereview.chromium.org/122373003/diff/80001/experimental/SkV8Example/JsContext.h#newcode55 experimental/SkV8Example/JsContext.h:55: const PropertyCallbackInfo<void>& info, On 2014/01/07 18:36:15, robertphillips wrote: > ...
6 years, 11 months ago (2014-01-07 18:46:20 UTC) #4
jcgregorio
On 2014/01/07 18:36:14, robertphillips wrote: > Why do we have two copies of the .js ...
6 years, 11 months ago (2014-01-07 18:47:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/122373003/130001
6 years, 11 months ago (2014-01-07 18:48:41 UTC) #6
commit-bot: I haz the power
Change committed as 12946
6 years, 11 months ago (2014-01-07 19:00:31 UTC) #7
robertphillips
6 years, 11 months ago (2014-01-07 19:57:08 UTC) #8
Message was sent while issue was closed.
Sk8 may be a little too cryptic - how about SkV8 or V8?

Powered by Google App Engine
This is Rietveld 408576698