Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2743)

Unified Diff: cc/layers/viewport.h

Issue 1223713004: Cleanup viewport scrolling for future scroll customization work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix value of report_overscroll_only_for_scrollable_axes on Aura. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/viewport.cc » ('j') | cc/trees/layer_tree_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/viewport.h
diff --git a/cc/layers/viewport.h b/cc/layers/viewport.h
index 01885d7774f73ec86c765a8d4f9d63298d9e79bd..7a9234871ac89516c14688ce20bf91129bb182cb 100644
--- a/cc/layers/viewport.h
+++ b/cc/layers/viewport.h
@@ -25,12 +25,6 @@ class CC_EXPORT Viewport {
// determined.
static const int kPinchZoomSnapMarginDips = 100;
- struct ScrollResult {
- gfx::Vector2dF applied_delta;
- gfx::Vector2dF unused_scroll_delta;
- gfx::Vector2dF top_controls_applied_delta;
- };
-
static scoped_ptr<Viewport> Create(LayerTreeHostImpl* host_impl);
// Differs from scrolling in that only the visual viewport is moved, without
@@ -39,10 +33,10 @@ class CC_EXPORT Viewport {
// Scrolls the viewport, applying the unique bubbling between the inner and
// outer viewport. Scrolls can be consumed by top controls.
- ScrollResult ScrollBy(const gfx::Vector2dF& delta,
- const gfx::Point& viewport_point,
- bool is_wheel_scroll,
- bool affect_top_controls);
+ gfx::Vector2dF ScrollBy(const gfx::Vector2dF& delta,
+ const gfx::Point& viewport_point,
+ bool is_direct_manipulation,
+ bool affect_top_controls);
void PinchUpdate(float magnify_delta, const gfx::Point& anchor);
void PinchEnd();
« no previous file with comments | « no previous file | cc/layers/viewport.cc » ('j') | cc/trees/layer_tree_host_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698