Convert chrome_elf_unittests to run exclusively on Swarming

Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinAsanCov tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)

Ran:
  ./manage.py --convert chrome_elf_unittests

BUG=98637
TBR=caitkp

Committed: https://crrev.com/e782a76f147e8f1cef0892ebdbd05e58c9c34f97
Cr-Commit-Position: refs/heads/master@{#375581}

[Nico, 2016-02-15 19:47:45]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-15 19:47:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1223703002/40001

[commit-bot: I haz the power, 2016-02-15 19:50:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-15 19:50:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2016-02-15 20:06:57]

Description was changed from

==========
Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)

Ran:
  ./manage.py --convert chrome_elf_unittests

BUG=98637
==========

to

==========
Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinAsanCov tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)

Ran:
  ./manage.py --convert chrome_elf_unittests

R=
BUG=98637
==========

[M-A Ruel, 2016-02-15 23:56:47]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2016-02-15 23:56:48]

https://codereview.chromium.org/1223703002/diff/120001/chrome_elf/chrome_elf_...
File chrome_elf/chrome_elf_unittests.isolate (right):

https://codereview.chromium.org/1223703002/diff/120001/chrome_elf/chrome_elf_...
chrome_elf/chrome_elf_unittests.isolate:5: 'conditions': [
Please use double quotes.

I assume your first thought is "Why?". Well, the truth is uglier than you could
even imagine.

.isolate is GYP inspired, so it could be included in a GYP file. So it is
essentially a python dialect. It's obviously a bad idea in hindsight but hey, it
was cool.

The problem is: how do you read python in Go? Well, it's not easy ... except
that the GYP dialect also _happens_ to be valid JSON5. I can feel your anxiety
now. Yes, it's as bad as the image that just crossed your mind, you have to use
double quotes because it's parsed as json5 in Go and as python in python.

At that point I can hear you screaming in suffering but keep in mind we'll
delete it once we migrated to GN, so that's why I appreciate this much the work
you did to make clang-on-windows to work with GN.

[Nico, 2016-02-16 01:33:14]

https://codereview.chromium.org/1223703002/diff/120001/chrome_elf/chrome_elf_...
File chrome_elf/chrome_elf_unittests.isolate (right):

https://codereview.chromium.org/1223703002/diff/120001/chrome_elf/chrome_elf_...
chrome_elf/chrome_elf_unittests.isolate:5: 'conditions': [
That sounds crazy, but ok. But: All .isolate files I've looked at just now use
single quotes. How does that work then?
https://code.google.com/p/chromium/codesearch#search/&q=%5C'%20file:%5C.isola...

[M-A Ruel, 2016-02-16 01:51:53]

https://codereview.chromium.org/1223703002/diff/120001/chrome_elf/chrome_elf_...
File chrome_elf/chrome_elf_unittests.isolate (right):

https://codereview.chromium.org/1223703002/diff/120001/chrome_elf/chrome_elf_...
chrome_elf/chrome_elf_unittests.isolate:5: 'conditions': [
On 2016/02/16 01:33:14, Nico wrote:
> That sounds crazy, but ok. But: All .isolate files I've looked at just now use
> single quotes. How does that work then?
> https://code.google.com/p/chromium/codesearch#search/&q=%5C

Yes ignore me, the error is elsewhere. I mean, the json5 thing is true but the
single quotes is what is needed.

https://codereview.chromium.org/1223703002/diff/120001/chrome_elf/chrome_elf_...
chrome_elf/chrome_elf_unittests.isolate:17: 'includes': [
You can't do this in a condition. Includes are unconditional. That's the error.

[Nico, 2016-02-16 12:37:44]

Mariel: this has green try runs now. PTAL!

[chromium-reviews, 2016-02-16 12:43:51]

Sorry phone keyboard
On Feb 16, 2016 7:37 AM, <thakis@chromium.org> wrote:

>
> Mariel: this has green try runs now. PTAL!
> https://codereview.chromium.org/1223703002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2016-02-16 15:19:07]

lgtm

[Nico, 2016-02-16 15:19:18]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-02-16 15:20:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223703002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1223703002/140001

[commit-bot: I haz the power, 2016-02-16 15:29:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 15:29:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-02-16 15:35:53]

Description was changed from

==========
Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinAsanCov tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)

Ran:
  ./manage.py --convert chrome_elf_unittests

R=
BUG=98637
==========

to

==========
Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinAsanCov tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)

Ran:
  ./manage.py --convert chrome_elf_unittests

BUG=98637
TBR=caitkp
==========

[Nico, 2016-02-16 15:36:09]

thakis@chromium.org changed reviewers:
+ caitkp@chromium.org

[Nico, 2016-02-16 15:36:09]

tbr caitkp for chrome_elf/OWNERS

[Nico, 2016-02-16 15:36:13]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-02-16 15:36:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1223703002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1223703002/140001

[commit-bot: I haz the power, 2016-02-16 15:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 15:42:23]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[Nico, 2016-02-16 15:43:08]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-02-16 15:47:42]

Description was changed from

==========
Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinAsanCov tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)

Ran:
  ./manage.py --convert chrome_elf_unittests

BUG=98637
TBR=caitkp
==========

to

==========
Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinAsanCov tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)

Ran:
  ./manage.py --convert chrome_elf_unittests

BUG=98637
TBR=caitkp
==========

[commit-bot: I haz the power, 2016-02-16 15:47:43]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-02-16 22:52:56]

Description was changed from

==========
Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinAsanCov tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)

Ran:
  ./manage.py --convert chrome_elf_unittests

BUG=98637
TBR=caitkp
==========

to

==========
Convert chrome_elf_unittests to run exclusively on Swarming

0 configs already ran on Swarming
20 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: CrWinAsanCov tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)

Ran:
  ./manage.py --convert chrome_elf_unittests

BUG=98637
TBR=caitkp

Committed: https://crrev.com/e782a76f147e8f1cef0892ebdbd05e58c9c34f97
Cr-Commit-Position: refs/heads/master@{#375581}
==========

[commit-bot: I haz the power, 2016-02-16 22:52:57]

Patchset 8 (id:??) landed as
https://crrev.com/e782a76f147e8f1cef0892ebdbd05e58c9c34f97
Cr-Commit-Position: refs/heads/master@{#375581}