chrome_elf/chrome_elf_unittests.isolate - Issue 1223703002: Convert chrome_elf_unittests to run exclusively on Swarming

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_elf/chrome_elf_unittests.isolate

Issue 1223703002: Convert chrome_elf_unittests to run exclusively on Swarming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: foiled! Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'conditions': [
	M-A Ruel 2016/02/15 23:56:48 Please use double quotes. I assume your first tho Please use double quotes. I assume your first thought is "Why?". Well, the truth is uglier than you could even imagine. .isolate is GYP inspired, so it could be included in a GYP file. So it is essentially a python dialect. It's obviously a bad idea in hindsight but hey, it was cool. The problem is: how do you read python in Go? Well, it's not easy ... except that the GYP dialect also _happens_ to be valid JSON5. I can feel your anxiety now. Yes, it's as bad as the image that just crossed your mind, you have to use double quotes because it's parsed as json5 in Go and as python in python. At that point I can hear you screaming in suffering but keep in mind we'll delete it once we migrated to GN, so that's why I appreciate this much the work you did to make clang-on-windows to work with GN. Nico 2016/02/16 01:33:14 That sounds crazy, but ok. But: All .isolate files That sounds crazy, but ok. But: All .isolate files I've looked at just now use single quotes. How does that work then? https://code.google.com/p/chromium/codesearch#search/&q=%5C'%20file:%5C.isola... M-A Ruel 2016/02/16 01:51:53 Yes ignore me, the error is elsewhere. I mean, the Show quoted text On 2016/02/16 01:33:14, Nico wrote: > That sounds crazy, but ok. But: All .isolate files I've looked at just now use > single quotes. How does that work then? > https://code.google.com/p/chromium/codesearch#search/&q=%5C Yes ignore me, the error is elsewhere. I mean, the json5 thing is true but the single quotes is what is needed.
	6 ['OS=="win"', {

	7 'variables': {

	8 'command': [

	9 '<(PRODUCT_DIR)/chrome_elf_unittests<(EXECUTABLE_SUFFIX)',

	10 ],

	11 'files': [

	12 '<(PRODUCT_DIR)/blacklist_test_dll_1.dll',

	13 '<(PRODUCT_DIR)/blacklist_test_dll_2.dll',

	14 '<(PRODUCT_DIR)/blacklist_test_dll_3.dll',

	15 ],

	16 },

	17 'includes': [
	M-A Ruel 2016/02/16 01:51:53 You can't do this in a condition. Includes are unc You can't do this in a condition. Includes are unconditional. That's the error.
	18 '../base/base.isolate',

	19 ],

	20 }],

	21 ],

	22 }

OLD	NEW

« no previous file with comments | « chrome_elf/chrome_elf.gyp ('k') | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »