Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1223373002: Remove incorrect assert in WebLocalFrameImpl::load. (Closed)

Created:
5 years, 5 months ago by Charlie Reis
Modified:
5 years, 5 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, clamy, Avi (use Gerrit), site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove incorrect assert in WebLocalFrameImpl::load. We need to pass RedirectWithLockedBackForwardList for cross-process location.replace. BUG=317872 TEST=See bug for repro steps. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Nate: Camille added this assert when you asked whether load could be called with RedirectWithLockedBackForwardList: ...
5 years, 5 months ago (2015-07-09 17:40:59 UTC) #2
Nate Chapin
lgtm. I remember some discussion about renaming this enum value. Is that still desired? If ...
5 years, 5 months ago (2015-07-09 20:50:58 UTC) #3
Charlie Reis
On 2015/07/09 20:50:58, Nate Chapin wrote: > lgtm. I remember some discussion about renaming this ...
5 years, 5 months ago (2015-07-09 21:00:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223373002/1
5 years, 5 months ago (2015-07-09 21:00:42 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 21:05:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198630

Powered by Google App Engine
This is Rietveld 408576698