Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1220833004: Convert installer_util_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, grt (UTC plus 2), gab
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@5_sbox_validation_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert installer_util_unittests to run exclusively on Swarming 0 configs already ran on Swarming 7 used to run locally and were converted: - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert installer_util_unittests R=thakis@chromium.org BUG=98637 Committed: https://crrev.com/d56aeda10229d77ed2d72fc2d863b7be73a93286 Cr-Commit-Position: refs/heads/master@{#338449}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M build/gn_migration.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + chrome/installer_util_unittests.isolate View 1 1 chunk +8 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
M-A Ruel
Tested locally on Win7. It's possible that it fails on Vista x64 due to missing ...
5 years, 5 months ago (2015-07-03 20:49:34 UTC) #1
Nico
lgtm if the trybots like it
5 years, 5 months ago (2015-07-03 21:17:40 UTC) #2
grt (UTC plus 2)
<fingers crossed>
5 years, 5 months ago (2015-07-04 01:25:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220833004/20001
5 years, 5 months ago (2015-07-11 19:53:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/77430)
5 years, 5 months ago (2015-07-11 20:34:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220833004/20001
5 years, 5 months ago (2015-07-11 20:42:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/43437)
5 years, 5 months ago (2015-07-11 22:22:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220833004/20001
5 years, 5 months ago (2015-07-11 22:59:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-12 00:05:39 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-12 00:06:27 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d56aeda10229d77ed2d72fc2d863b7be73a93286
Cr-Commit-Position: refs/heads/master@{#338449}

Powered by Google App Engine
This is Rietveld 408576698