extensions/common/permissions/socket_permission_entry.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/socket_permission_entry.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/socket_permission_entry.cc

diff --git a/extensions/common/permissions/socket_permission_entry.cc b/extensions/common/permissions/socket_permission_entry.cc

index 6adf3077f874db00d3be0dcce0146d37154cefb8..8b2d355acc70a80e4d0413c77fb62a989350fb5f 100644

--- a/extensions/common/permissions/socket_permission_entry.cc

+++ b/extensions/common/permissions/socket_permission_entry.cc

@@ -178,7 +178,7 @@ bool SocketPermissionEntry::ParseHostPattern(

} else {

result.match_subdomains_ = false;

}

- result.pattern_.host = JoinString(host_components, kDot);

+ result.pattern_.host = base::JoinString(host_components, ".");

}

if (pattern_tokens.size() == 1 || pattern_tokens[1].empty() ||