extensions/common/permissions/permission_message_test_util.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permission_message_test_util.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/permission_message_test_util.cc

diff --git a/extensions/common/permissions/permission_message_test_util.cc b/extensions/common/permissions/permission_message_test_util.cc

index 47e99138afc460701289642b36acd371c42fdcda..32890fd079ddc6404c4188dc19eba2ddc452ad31 100644

--- a/extensions/common/permissions/permission_message_test_util.cc

+++ b/extensions/common/permissions/permission_message_test_util.cc

@@ -102,7 +102,7 @@ base::string16 MessagesVectorToString(

if (messages.empty())

return base::ASCIIToUTF16("\n");

return base::ASCIIToUTF16("\"") +

- JoinString(messages, base::ASCIIToUTF16("\"\n\"")) +

+ base::JoinString(messages, base::ASCIIToUTF16("\"\n\"")) +

base::ASCIIToUTF16("\"\n");

}