Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7341)

Unified Diff: chromecast/base/metrics/cast_metrics_helper.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome_launcher.cc ('k') | chromecast/base/process_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/metrics/cast_metrics_helper.cc
diff --git a/chromecast/base/metrics/cast_metrics_helper.cc b/chromecast/base/metrics/cast_metrics_helper.cc
index 6d07b4a93413c14cb1d2c4434a1ccf714f0193f3..218da4ac8b79f8e4109b4dd5e613641a6d48f205 100644
--- a/chromecast/base/metrics/cast_metrics_helper.cc
+++ b/chromecast/base/metrics/cast_metrics_helper.cc
@@ -78,12 +78,14 @@ std::string CastMetricsHelper::EncodeAppInfoIntoMetricsName(
const std::string& app_id,
const std::string& session_id,
const std::string& sdk_version) {
- std::vector<std::string> parts;
- parts.push_back(action_name);
- parts.push_back(app_id);
- parts.push_back(session_id);
- parts.push_back(sdk_version);
- return JoinString(parts, kMetricsNameAppInfoDelimiter);
+ std::string result(action_name);
+ result.push_back(kMetricsNameAppInfoDelimiter);
+ result.append(app_id);
+ result.push_back(kMetricsNameAppInfoDelimiter);
+ result.append(session_id);
+ result.push_back(kMetricsNameAppInfoDelimiter);
+ result.append(sdk_version);
+ return result;
}
// static
« no previous file with comments | « chrome/test/chromedriver/chrome_launcher.cc ('k') | chromecast/base/process_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698