Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/web_ui_browser_test.cc ('k') | chromecast/base/metrics/cast_metrics_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index 5a79d678006ab640e204ff690606710cd0fe2ef7..9c35f8f6e35d69b11d53f5ed998ac663c8dcdb0a 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -749,8 +749,8 @@ Status ProcessExtensions(const std::vector<std::string>& extensions,
}
if (extension_paths.size()) {
- base::FilePath::StringType extension_paths_value = JoinString(
- extension_paths, FILE_PATH_LITERAL(','));
+ base::FilePath::StringType extension_paths_value = base::JoinString(
+ extension_paths, base::FilePath::StringType(1, ','));
UpdateExtensionSwitch(switches, "load-extension", extension_paths_value);
}
bg_pages->swap(bg_pages_tmp);
« no previous file with comments | « chrome/test/base/web_ui_browser_test.cc ('k') | chromecast/base/metrics/cast_metrics_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698