chrome/installer/setup/update_active_setup_version_work_item.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/update_active_setup_version_work_item.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/setup/update_active_setup_version_work_item.cc

diff --git a/chrome/installer/setup/update_active_setup_version_work_item.cc b/chrome/installer/setup/update_active_setup_version_work_item.cc

index 4d35494245a443c6bcea13f078258141d7f1ca66..7372675a6fe013ac72632f24f30df1dfb54cb1b4 100644

--- a/chrome/installer/setup/update_active_setup_version_work_item.cc

+++ b/chrome/installer/setup/update_active_setup_version_work_item.cc

@@ -69,5 +69,5 @@ base::string16 UpdateActiveSetupVersionWorkItem::GetUpdatedActiveSetupVersion(

version_components[OS_UPGRADES] = base::UintToString16(previous_value + 1);

}

- return JoinString(version_components, L',');

+ return base::JoinString(version_components, L",");

}