Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8431)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index e8a3f091928cd9e3c74bac9d7556ffe8b329c55c..5070f17e7c2a3aae91affe42dae30cffd5277f87 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -69,14 +69,14 @@ std::string LegacyPermissionIDsToString(const PermissionMessageIDs& ids) {
std::vector<std::string> strs;
for (const PermissionMessage::ID& id : ids)
strs.push_back(base::IntToString(id));
- return base::StringPrintf("[ %s ]", JoinString(strs, ", ").c_str());
+ return base::StringPrintf("[ %s ]", base::JoinString(strs, ", ").c_str());
}
std::string PermissionIDsToString(const PermissionIDSet& ids) {
std::vector<std::string> strs;
for (const PermissionID& id : ids)
strs.push_back(base::IntToString(id.id()));
- return base::StringPrintf("[ %s ]", JoinString(strs, ", ").c_str());
+ return base::StringPrintf("[ %s ]", base::JoinString(strs, ", ").c_str());
}
std::string CoalescedPermissionIDsToString(
@@ -84,7 +84,7 @@ std::string CoalescedPermissionIDsToString(
std::vector<std::string> strs;
for (const CoalescedPermissionMessage& msg : msgs)
strs.push_back(PermissionIDsToString(msg.permissions()));
- return JoinString(strs, " ");
+ return base::JoinString(strs, " ");
}
// Check that the given |permissions| produce a single warning message,

Powered by Google App Engine
This is Rietveld 408576698