chrome/browser/extensions/requirements_checker_browsertest.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/requirements_checker_browsertest.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/requirements_checker_browsertest.cc

diff --git a/chrome/browser/extensions/requirements_checker_browsertest.cc b/chrome/browser/extensions/requirements_checker_browsertest.cc

index efda73977846b759d78290e747d5d30a4252fd26..7ff03d91949467c41dbb10e9aef0dd686a87616e 100644

--- a/chrome/browser/extensions/requirements_checker_browsertest.cc

+++ b/chrome/browser/extensions/requirements_checker_browsertest.cc

@@ -65,7 +65,7 @@ class RequirementsCheckerBrowserTest : public ExtensionBrowserTest {

" \"entries\": [\n"

" {\n"

" \"id\": 1,\n"

- " \"features\": [\"" + JoinString(features, "\", \"") + "\"]\n"

+ " \"features\": [\"" + base::JoinString(features, "\", \"") + "\"]\n"

" }\n"

" ]\n"

"}";