chrome/browser/extensions/chrome_content_verifier_delegate.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_content_verifier_delegate.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/chrome_content_verifier_delegate.cc

diff --git a/chrome/browser/extensions/chrome_content_verifier_delegate.cc b/chrome/browser/extensions/chrome_content_verifier_delegate.cc

index 5e412e76ea2ba4e0b0c5eff400b2f27a72e7243f..c181e5eb93edf9c29199cc353f777cf70bc24d30 100644

--- a/chrome/browser/extensions/chrome_content_verifier_delegate.cc

+++ b/chrome/browser/extensions/chrome_content_verifier_delegate.cc

@@ -135,7 +135,7 @@ GURL ChromeContentVerifierDelegate::GetSignatureFetchUrl(

parts.push_back("id=" + extension_id);

parts.push_back("v=" + version.GetString());

std::string x_value =

- net::EscapeQueryParamValue(JoinString(parts, "&"), true);

+ net::EscapeQueryParamValue(base::JoinString(parts, "&"), true);

std::string query = "response=redirect&x=" + x_value;

GURL base_url = extension_urls::GetWebstoreUpdateUrl();