chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc ('k') | chrome/browser/extensions/chrome_content_verifier_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

diff --git a/chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc b/chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

index 9110b025cb89a03fb33e238699d17e9434afa62c..2385a3e311faa62fbf8753785b94e00c3a06304e 100644

--- a/chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

+++ b/chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

@@ -168,7 +168,7 @@ CryptoVerifyImpl::Credentials::Credentials(

data_parts.push_back(properties.device_bssid);

data_parts.push_back(properties.public_key);

data_parts.push_back(properties.nonce);

- unsigned_data = JoinString(data_parts, ",");

+ unsigned_data = base::JoinString(data_parts, ",");

device_bssid = properties.device_bssid;

public_key = properties.public_key;