S3 devices should not be rebooted in provision step.

S3 devices should not be rebooted in provision step.

Rebooting s3 devices causes device to be flaky during the deploy step. This is
likely because WaitForPackageManager() does not wait long enough on the s3
devices. I've verified locally on the bot that without the reboot in the
provision step, the devices are more reliable (i.e. deploy step passes).

BUG=321063
TBR=frankf@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243542

[navabi, 2014-01-07 05:40:21]

See accompanying change:
https://chrome-internal-review.googlesource.com/#/c/151268/1

[bulach, 2014-01-07 15:43:08]

https://codereview.chromium.org/122313008/diff/30001/build/android/buildbot/b...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/122313008/diff/30001/build/android/buildbot/b...
build/android/buildbot/bb_device_steps.py:581: parser.add_option('--s3-devices',
action='store_true',
from the other patch: it'd be better to keep --reboot (or --no-reboot if you
want to invert the logic), so this script doesn't know about specific devices..

[navabi, 2014-01-07 17:42:47]

On 2014/01/07 15:43:08, bulach wrote:
>
https://codereview.chromium.org/122313008/diff/30001/build/android/buildbot/b...
> File build/android/buildbot/bb_device_steps.py (right):
> 
>
https://codereview.chromium.org/122313008/diff/30001/build/android/buildbot/b...
> build/android/buildbot/bb_device_steps.py:581:
parser.add_option('--s3-devices',
> action='store_true',
> from the other patch: it'd be better to keep --reboot (or --no-reboot if you
> want to invert the logic), so this script doesn't know about specific
devices..

Thanks Marcus. Good point. PTAL.

[bulach, 2014-01-07 18:01:56]

lgtm, thanks!

[commit-bot: I haz the power, 2014-01-07 18:04:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/122313008/70002

[commit-bot: I haz the power, 2014-01-07 18:22:35]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-07 18:32:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/122313008/70002

[commit-bot: I haz the power, 2014-01-07 18:59:22]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-07 19:18:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/122313008/70002

[commit-bot: I haz the power, 2014-01-08 00:29:30]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 04:08:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/122313008/70002

[commit-bot: I haz the power, 2014-01-08 06:30:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/122313008/70002

[commit-bot: I haz the power, 2014-01-08 12:56:51]

Change committed as 243542