build/android/buildbot/bb_device_steps.py - Issue 122313008: S3 devices should not be rebooted in provision step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 122313008: S3 devices should not be rebooted in provision step. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change option to be --no-reboot rather than device specific. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/buildbot/bb_device_steps.py

diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py

index 26708cd1c9346cc7e41a882989c7514fb6120544..178a6c780b644d982a1e929df9bfe7afdd139f58 100755

--- a/build/android/buildbot/bb_device_steps.py

+++ b/build/android/buildbot/bb_device_steps.py

@@ -402,7 +402,7 @@ def ProvisionDevices(options):

adb.RestartAdbServer()

RunCmd(['sleep', '1'])

- if options.reboot:

+ if not options.no_reboot:

RebootDevices()

provision_cmd = ['build/android/provision_devices.py', '-t', options.target]

if options.auto_reconnect:

@@ -577,8 +577,8 @@ def GetDeviceStepsOptParser():

parser.add_option('--asan', action='store_true', help='Run tests with asan.')

parser.add_option('--install', metavar='<apk name>',

help='Install an apk by name')

- parser.add_option('--reboot', action='store_true',

- help='Reboot devices before running tests')

+ parser.add_option('--no-reboot', action='store_true',

+ help='Do not reboot devices during provisioning.')

parser.add_option('--coverage-bucket',

help=('Bucket name to store coverage results. Coverage is '

'only run if this is set.'))

« no previous file with comments | « no previous file | build/android/buildbot/bb_run_bot.py » ('j') | no next file with comments »