Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1223093004: [arm] Fix missing CheckBuffer for branches. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Yang, rmcilroy
CC:
v8-dev, Rodolph Perfetta (ARM)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix missing CheckBuffer for branches. The b, bl and blx methods that take labels basically ignore the constant pool check and just block the constant pool for the next instruction. This way a long enough sequence of those instructions will block can potentially block the constant pool emission for too long. BUG=v8:4292 LOG=y R=yangguo@chromium.org Committed: https://crrev.com/d05538827e32ebfed5297653266d65c11e438148 Cr-Commit-Position: refs/heads/master@{#29550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -4 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-09 09:08:08 UTC) #1
Benedikt Meurer
Yang: PTAL Ross, Rodolph: FYI This doesn't yet fix the bug 4292, but it's related, ...
5 years, 5 months ago (2015-07-09 09:09:24 UTC) #2
Yang
On 2015/07/09 09:09:24, Benedikt Meurer wrote: > Yang: PTAL > Ross, Rodolph: FYI > > ...
5 years, 5 months ago (2015-07-09 09:13:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223093004/1
5 years, 5 months ago (2015-07-09 09:13:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 09:33:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d05538827e32ebfed5297653266d65c11e438148 Cr-Commit-Position: refs/heads/master@{#29550}
5 years, 5 months ago (2015-07-09 09:33:44 UTC) #7
rmcilroy
5 years, 5 months ago (2015-07-09 09:51:39 UTC) #8
Message was sent while issue was closed.
On 2015/07/09 09:33:44, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/d05538827e32ebfed5297653266d65c11e438148
> Cr-Commit-Position: refs/heads/master@{#29550}

lgtm, good catch.

Powered by Google App Engine
This is Rietveld 408576698