Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1223033002: Remove dom_utils. (Closed)

Created:
5 years, 5 months ago by dglazkov
Modified:
5 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dom_utils. 1) These types of operations shouldn't be done in the content API. 2) The last call site no longer needs it in Blink after https://codereview.chromium.org/1208423015 landed. R=jochen,jam BUG=508151 Committed: https://crrev.com/bdaac789c082c37217de4d1128c3230764c1697e Cr-Commit-Position: refs/heads/master@{#337988}

Patch Set 1 #

Patch Set 2 : Removed the under-patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -53 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/dom_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D content/renderer/dom_utils.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dglazkov
5 years, 5 months ago (2015-07-08 17:59:53 UTC) #1
dglazkov
Whoops, needs a rebase to remove the under-patch.
5 years, 5 months ago (2015-07-08 18:12:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223033002/20001
5 years, 5 months ago (2015-07-08 21:06:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-08 22:43:30 UTC) #6
dglazkov
On 2015/07/08 at 22:43:30, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
5 years, 5 months ago (2015-07-08 22:47:15 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-09 04:01:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223033002/20001
5 years, 5 months ago (2015-07-09 05:09:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 05:13:19 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 05:14:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdaac789c082c37217de4d1128c3230764c1697e
Cr-Commit-Position: refs/heads/master@{#337988}

Powered by Google App Engine
This is Rietveld 408576698