Issue 1208423015: Make sendPings accommodate any context node.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1208423015: Make sendPings accommodate any context node. (Closed)

Created:
5 years, 5 months ago by dglazkov

Modified:
5 years, 5 months ago

Reviewers:
esprehn

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Make sendPings accommodate any context node. When called on the content API side, there's some extra massaging of the argument going on -- because sendPings expects precisely the anchor element. This massaging is better done on the Blink side, since we have nicer and smarter functions to do that. BUG=508151 R=esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198517

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	Source/core/dom/Node.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Node.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	public/web/WebLocalFrame.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208423015/1

5 years, 5 months ago (2015-07-08 16:35:57 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-08 17:44:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198517

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages