Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1222943003: ARM32: Lower more integer intrinsics and test. (Closed)

Created:
5 years, 5 months ago by jvoung (off chromium)
Modified:
5 years, 5 months ago
Reviewers:
Karl, Jim Stichnoth, John, JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ARM32: Lower more integer intrinsics and test. Lower stacksave/restore. Lower ctlz, cttz, bswap, and popcount. Popcount is just done with a helper call. Ctz can use the clz instruction after reversing the bits. We can only crosstest stacksave/restore for now which happens to be written in C for the C99 VLAs. The CXX crosstests I can't seem to compile with the arm-cross-g++ (missing headers), so I will check that later after resolving the cross compilation issue. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f645d8539e6dd8d0d7d6b604f36b9cc7b05d1886

Patch Set 1 #

Patch Set 2 : lower popcount too, and add comments #

Patch Set 3 : clang-format #

Patch Set 4 : move comment #

Patch Set 5 : typo #

Total comments: 2

Patch Set 6 : move to TargetLowering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -51 lines) Patch
M Makefile.standalone View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/IceInstARM32.h View 6 chunks +13 lines, -7 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M src/IceInstMIPS32.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/IceTargetLowering.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 2 3 4 5 3 chunks +14 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 3 4 7 chunks +119 lines, -13 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 1 21 chunks +91 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 5 months ago (2015-07-08 18:00:02 UTC) #2
John
lgtm https://codereview.chromium.org/1222943003/diff/80001/src/IceTargetLoweringARM32.h File src/IceTargetLoweringARM32.h (right): https://codereview.chromium.org/1222943003/diff/80001/src/IceTargetLoweringARM32.h#newcode379 src/IceTargetLoweringARM32.h:379: Context.getLastInserted()->setDestNonKillable(); _set_dest_nonkillable is used in pretty much every ...
5 years, 5 months ago (2015-07-08 21:49:21 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/1222943003/diff/80001/src/IceTargetLoweringARM32.h File src/IceTargetLoweringARM32.h (right): https://codereview.chromium.org/1222943003/diff/80001/src/IceTargetLoweringARM32.h#newcode379 src/IceTargetLoweringARM32.h:379: Context.getLastInserted()->setDestNonKillable(); On 2015/07/08 21:49:21, John wrote: > _set_dest_nonkillable is ...
5 years, 5 months ago (2015-07-09 01:11:24 UTC) #4
jvoung (off chromium)
5 years, 5 months ago (2015-07-09 17:35:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 (id:90001) manually as
f645d8539e6dd8d0d7d6b604f36b9cc7b05d1886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698