Issue 12229002: Misc cleanups in Drive code.

Issue 12229002: Misc cleanups in Drive code. (Closed)

Created:
7 years, 10 months ago by kinaba

Modified:
7 years, 10 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Misc cleanups in Drive code. Typo fix, style fix, unused #include/forward-declarations clean up, adding const, reordering declarations properly, etc. BUG=none. TEST=it compiles. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181871

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -37 lines)			Patch
M	chrome/browser/chromeos/drive/drive_feed_loader_observer.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system_metadata.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system_util.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler.h	View	1	1 chunk	+3 lines, -4 lines	1 comment	Download
M	chrome/browser/chromeos/drive/drive_scheduler.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_system_service.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/search_metadata.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/search_metadata.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/auth_service.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/google_apis/auth_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/auth_service_interface.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/google_apis/base_operations.h	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_operations.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/drive_api_service.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_service.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_parser.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_service.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_url_generator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/test_util.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/google_apis/time_util.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm with pedantic nits. https://codereview.chromium.org/12229002/diff/10001/chrome/browser/chromeos/drive/search_metadata.h File chrome/browser/chromeos/drive/search_metadata.h (right): https://codereview.chromium.org/12229002/diff/10001/chrome/browser/chromeos/drive/search_metadata.h#newcode11 chrome/browser/chromeos/drive/search_metadata.h:11: #include "chrome/browser/chromeos/drive/drive_file_system_interface.h" This include can ...

7 years, 10 months ago (2013-02-08 11:42:21 UTC) #2

kinaba

https://codereview.chromium.org/12229002/diff/10001/chrome/browser/chromeos/drive/search_metadata.h File chrome/browser/chromeos/drive/search_metadata.h (right): https://codereview.chromium.org/12229002/diff/10001/chrome/browser/chromeos/drive/search_metadata.h#newcode11 chrome/browser/chromeos/drive/search_metadata.h:11: #include "chrome/browser/chromeos/drive/drive_file_system_interface.h" On 2013/02/08 11:42:21, hashimoto wrote: > This ...

7 years, 10 months ago (2013-02-12 03:38:07 UTC) #3

hashimoto

7 years, 10 months ago (2013-02-12 03:42:39 UTC) #4

lgtm

https://codereview.chromium.org/12229002/diff/2019/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_scheduler.h (right):

https://codereview.chromium.org/12229002/diff/2019/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_scheduler.h:371: bool initialized_;
Good catch.

Expand Messages | Collapse Messages