Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Side by Side Diff: chrome/browser/google_apis/gdata_wapi_service.h

Issue 12229002: Misc cleanups in Drive code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_SERVICE_H_ 5 #ifndef CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_SERVICE_H_
6 #define CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_SERVICE_H_ 6 #define CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_SERVICE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 const std::string& directory_name, 108 const std::string& directory_name,
109 const GetResourceEntryCallback& callback) OVERRIDE; 109 const GetResourceEntryCallback& callback) OVERRIDE;
110 virtual void InitiateUpload( 110 virtual void InitiateUpload(
111 const InitiateUploadParams& params, 111 const InitiateUploadParams& params,
112 const InitiateUploadCallback& callback) OVERRIDE; 112 const InitiateUploadCallback& callback) OVERRIDE;
113 virtual void ResumeUpload( 113 virtual void ResumeUpload(
114 const ResumeUploadParams& params, 114 const ResumeUploadParams& params,
115 const UploadRangeCallback& callback) OVERRIDE; 115 const UploadRangeCallback& callback) OVERRIDE;
116 virtual void GetUploadStatus( 116 virtual void GetUploadStatus(
117 UploadMode upload_mode, 117 UploadMode upload_mode,
118 const FilePath& drive_file_path, 118 const FilePath& drive_file_path,
hashimoto 2013/02/08 11:42:21 Please make this base::FilePath in favor of consis
kinaba 2013/02/12 03:38:07 It seems unqualified FilePath was purged globally
119 const GURL& upload_url, 119 const GURL& upload_url,
120 int64 content_length, 120 int64 content_length,
121 const UploadRangeCallback& callback) OVERRIDE; 121 const UploadRangeCallback& callback) OVERRIDE;
122 virtual void AuthorizeApp( 122 virtual void AuthorizeApp(
123 const GURL& edit_url, 123 const GURL& edit_url,
124 const std::string& app_id, 124 const std::string& app_id,
125 const AuthorizeAppCallback& callback) OVERRIDE; 125 const AuthorizeAppCallback& callback) OVERRIDE;
126 126
127 private: 127 private:
128 OperationRegistry* operation_registry() const; 128 OperationRegistry* operation_registry() const;
129 129
130 // AuthService::Observer override. 130 // AuthService::Observer override.
131 virtual void OnOAuth2RefreshTokenChanged() OVERRIDE; 131 virtual void OnOAuth2RefreshTokenChanged() OVERRIDE;
132 132
133 // DriveServiceObserver Overrides 133 // DriveServiceObserver Overrides
134 virtual void OnProgressUpdate( 134 virtual void OnProgressUpdate(
135 const OperationProgressStatusList& list) OVERRIDE; 135 const OperationProgressStatusList& list) OVERRIDE;
136 136
137 net::URLRequestContextGetter* url_request_context_getter_; // Not owned. 137 net::URLRequestContextGetter* url_request_context_getter_; // Not owned.
138 scoped_ptr<OperationRunner> runner_; 138 scoped_ptr<OperationRunner> runner_;
139 ObserverList<DriveServiceObserver> observers_; 139 ObserverList<DriveServiceObserver> observers_;
140 // Operation objects should hold a copy of this, rather than a const 140 // Operation objects should hold a copy of this, rather than a const
141 // reference, as they may outlive this object. 141 // reference, as they may outlive this object.
142 GDataWapiUrlGenerator url_generator_; 142 const GDataWapiUrlGenerator url_generator_;
143 const std::string custom_user_agent_; 143 const std::string custom_user_agent_;
144 144
145 DISALLOW_COPY_AND_ASSIGN(GDataWapiService); 145 DISALLOW_COPY_AND_ASSIGN(GDataWapiService);
146 }; 146 };
147 147
148 } // namespace google_apis 148 } // namespace google_apis
149 149
150 #endif // CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_SERVICE_H_ 150 #endif // CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698