Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 1222713012: Make .s files generate cflags for ninja (Closed)

Created:
5 years, 5 months ago by Peter Mayo
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make .s files generate cflags for ninja With toolchains that use cc as an assembler cflags are expected to get passed along to the assembler as well. In the ninja build writer this only happens if the source set contains .asm, .c, .cpp, ... but not .s files. While we could set this up to map through the tool type map, that limits future flexibility too. This doesn't seem to affect chromium until arm platforms are compiled. BUG=507943 TEST=https://code.google.com/p/chromium/issues/detail?id=507943#c1 R=brettw@chromium.org Committed: https://crrev.com/3f87569bb10ffc8a925ed75147b783d089a2bc4f Cr-Commit-Position: refs/heads/master@{#337891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Mayo
PTAL
5 years, 5 months ago (2015-07-08 02:56:22 UTC) #1
Dirk Pranke
lgtm
5 years, 5 months ago (2015-07-08 19:37:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222713012/1
5 years, 5 months ago (2015-07-08 19:44:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 20:00:03 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 20:01:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f87569bb10ffc8a925ed75147b783d089a2bc4f
Cr-Commit-Position: refs/heads/master@{#337891}

Powered by Google App Engine
This is Rietveld 408576698