Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 1222713012: Make .s files generate cflags for ninja (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index a0a4e9fc6ce3c3036e7d44744d10faecb1b5e1d0..1fc06b26e5787debef792f70a551dabd259ee22c 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -351,12 +351,12 @@ void NinjaBinaryTargetWriter::WriteCompilerVars(
EscapeOptions opts = GetFlagOptions();
if (used_types.Get(SOURCE_C) || used_types.Get(SOURCE_CPP) ||
used_types.Get(SOURCE_M) || used_types.Get(SOURCE_MM) ||
- used_types.Get(SOURCE_ASM)) {
+ used_types.Get(SOURCE_S) || used_types.Get(SOURCE_ASM)) {
WriteOneFlag(SUBSTITUTION_CFLAGS, false, Toolchain::TYPE_NONE,
&ConfigValues::cflags, opts);
}
if (used_types.Get(SOURCE_C) || used_types.Get(SOURCE_M) ||
- used_types.Get(SOURCE_ASM)) {
+ used_types.Get(SOURCE_S) || used_types.Get(SOURCE_ASM)) {
WriteOneFlag(SUBSTITUTION_CFLAGS_C, has_precompiled_headers,
Toolchain::TYPE_CC, &ConfigValues::cflags_c, opts);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698