Issue 12226125: temporary fix for requestAutocomplete crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12226125: temporary fix for requestAutocomplete crash (Closed)

Created:
7 years, 10 months ago by Evan Stade

Modified:
7 years, 10 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

temporary fix for requestAutocomplete crash fixes the crash while I wait for a review on 12208070 BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182108

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12226125/1

7 years, 10 months ago (2013-02-12 22:30:34 UTC) #3

commit-bot: I haz the power

7 years, 10 months ago (2013-02-12 22:30:36 UTC) #4

Failed to apply patch for
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
  Hunk #1 FAILED at 390.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc.rej

Patch:       chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index
a6e86b0eb50205c046e923bc317f1332f698bbdb..131b8257365c9c9ef81ba2194e0d8385a6157c9b
100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -390,6 +390,8 @@ gfx::Image
AutofillDialogControllerImpl::SuggestionIconForSection(
 
   std::string item_key =
       suggested_cc_.GetItemKeyAt(suggested_cc_.checked_item());
+  if (item_key.empty())
+    return gfx::Image();
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   CreditCard* card = GetManager()->GetCreditCardByGUID(item_key);
   return rb.GetImageNamed(card->IconResourceId());

Expand Messages | Collapse Messages