chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 12226125: temporary fix for requestAutocomplete crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 12226125: temporary fix for requestAutocomplete crash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index a6e86b0eb50205c046e923bc317f1332f698bbdb..131b8257365c9c9ef81ba2194e0d8385a6157c9b 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -390,6 +390,8 @@ gfx::Image AutofillDialogControllerImpl::SuggestionIconForSection(

std::string item_key =

suggested_cc_.GetItemKeyAt(suggested_cc_.checked_item());

+ if (item_key.empty())

+ return gfx::Image();

ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();

CreditCard* card = GetManager()->GetCreditCardByGUID(item_key);

return rb.GetImageNamed(card->IconResourceId());

« no previous file with comments | « no previous file | no next file » | no next file with comments »