Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 12225111: Make remoting_unittests build on Win64 (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Make remoting_unittests build on Win64 Two simple compilation fixes and some c4267 build suppressions. BUG=166496 BUG=167187 R=wez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181650

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M remoting/host/disconnect_window_win.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jschuh
Minor fixes for win64.
7 years, 10 months ago (2013-02-10 00:01:41 UTC) #1
Wez
LGTM
7 years, 10 months ago (2013-02-10 06:50:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12225111/4001
7 years, 10 months ago (2013-02-10 13:55:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=110184
7 years, 10 months ago (2013-02-10 16:05:03 UTC) #4
alexeypa (please no reviews)
Have you guys considered enabling /Wp64 (http://msdn.microsoft.com/en-us/library/yt4xw8fh(v=vs.100).aspx) on targets that are free from C4267 warnings? ...
7 years, 10 months ago (2013-02-11 17:12:14 UTC) #5
alexeypa (please no reviews)
On 2013/02/11 17:12:14, alexeypa wrote: > Have you guys considered enabling /Wp64 > (http://msdn.microsoft.com/en-us/library/yt4xw8fh%28v=vs.100%29.aspx) on ...
7 years, 10 months ago (2013-02-11 17:20:53 UTC) #6
jschuh
7 years, 10 months ago (2013-02-11 17:31:01 UTC) #7
Message was sent while issue was closed.
On 2013/02/11 17:20:53, alexeypa wrote:
> On 2013/02/11 17:12:14, alexeypa wrote:
> > Have you guys considered enabling /Wp64
> > (http://msdn.microsoft.com/en-us/library/yt4xw8fh%2528v=vs.100%2529.aspx) on
> targets
> > that are free from C4267 warnings? This will make sure that x86 build will
> fail
> > if a new C4267 warning will be introduced in such a target.
> 
> Maybe it is not such a great idea. I tried it on targets in src/remoting and
> got:
> 
> > cl : Command line warning D9035 : option 'Wp64' has been deprecated and will
> be removed in a future release
> >
d:\src\chrome\src\third_party\platformsdk_win8\files\include\um\winnt.h(8037)
> : error C2220: warning treated as error - no 'object' file generated
> >
d:\src\chrome\src\third_party\platformsdk_win8\files\include\um\winnt.h(8037)
> : warning C4312: 'type cast' : conversion from 'LONG' to 'PVOID' of greater
size
> > ...
> 
> So not only the option is deprecated, but Win 8 SDK gives the size warning. :(

The windows build treats warnings as errors, so we're already getting that
behavior. That's why we're suppressing the warnings for now, but as narrowly as
we can. :)

Powered by Google App Engine
This is Rietveld 408576698