Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 12225022: Delete kBrowserAppName in favor of IDS_SHORT_PRODUCT_NAME. (Closed)

Created:
7 years, 10 months ago by Alexei Svitkine (slow)
Modified:
7 years, 10 months ago
Reviewers:
sail, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Delete kBrowserAppName in favor of IDS_SHORT_PRODUCT_NAME. BUG=none TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180878

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M chrome/browser/memory_details_linux.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexei Svitkine (slow)
7 years, 10 months ago (2013-02-05 20:58:44 UTC) #1
sail
https://codereview.chromium.org/12225022/diff/5001/chrome/test/mini_installer_test/mini_installer_test_constants.cc File chrome/test/mini_installer_test/mini_installer_test_constants.cc (left): https://codereview.chromium.org/12225022/diff/5001/chrome/test/mini_installer_test/mini_installer_test_constants.cc#oldcode24 chrome/test/mini_installer_test/mini_installer_test_constants.cc:24: const wchar_t kBrowserAppName[] = L"Google - Google Chrome"; this ...
7 years, 10 months ago (2013-02-05 21:04:54 UTC) #2
sail
https://codereview.chromium.org/12225022/diff/5001/chrome/test/mini_installer_test/mini_installer_test_constants.cc File chrome/test/mini_installer_test/mini_installer_test_constants.cc (left): https://codereview.chromium.org/12225022/diff/5001/chrome/test/mini_installer_test/mini_installer_test_constants.cc#oldcode24 chrome/test/mini_installer_test/mini_installer_test_constants.cc:24: const wchar_t kBrowserAppName[] = L"Google - Google Chrome"; On ...
7 years, 10 months ago (2013-02-05 21:05:30 UTC) #3
Alexei Svitkine (slow)
Hmm, memory_details_linux.cc doesn't compile with the grt include. But the mac and windows implementations have ...
7 years, 10 months ago (2013-02-05 21:13:49 UTC) #4
Alexei Svitkine (slow)
On 2013/02/05 21:13:49, Alexei Svitkine wrote: > Hmm, memory_details_linux.cc doesn't compile with the grt include. ...
7 years, 10 months ago (2013-02-05 21:54:32 UTC) #5
sky
LGTM
7 years, 10 months ago (2013-02-05 22:33:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/12225022/15002
7 years, 10 months ago (2013-02-05 22:42:40 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-06 02:57:32 UTC) #8
Message was sent while issue was closed.
Change committed as 180878

Powered by Google App Engine
This is Rietveld 408576698