Issue 1222483002: Remove the ability to load ".sky" files

Issue 1222483002: Remove the ability to load ".sky" files (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove the ability to load ".sky" files Please use ".dart" files instead. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a6e86706f7f759efe509823cf1ea5c172c73416e

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -330 lines)			Patch
M	sky/engine/public/web/WebView.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	1 chunk	+1 line, -15 lines	1 comment	Download
M	sky/shell/ui/engine.h	View	4 chunks	+0 lines, -19 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	12 chunks	+1 line, -104 lines	0 comments	Download
M	sky/viewer/document_view.h	View	5 chunks	+0 lines, -28 lines	0 comments	Download
M	sky/viewer/document_view.cc	View	13 chunks	+7 lines, -151 lines	0 comments	Download
M	sky/viewer/internals.cc	View	2 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm LGTM with great righteousness. https://codereview.chromium.org/1222483002/diff/1/sky/engine/web/WebViewImpl.cpp File sky/engine/web/WebViewImpl.cpp (right): https://codereview.chromium.org/1222483002/diff/1/sky/engine/web/WebViewImpl.cpp#newcode97 sky/engine/web/WebViewImpl.cpp:97: CRASH(); // WebView is ...

5 years, 5 months ago (2015-06-30 21:45:04 UTC) #2

abarth-chromium

On 2015/06/30 at 21:45:04, ianh wrote: > lgtm > > LGTM with great righteousness. > ...

5 years, 5 months ago (2015-06-30 21:48:06 UTC) #3

abarth-chromium

5 years, 5 months ago (2015-06-30 21:48:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a6e86706f7f759efe509823cf1ea5c172c73416e (presubmit successful).

Expand Messages | Collapse Messages