Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: sky/engine/web/WebViewImpl.cpp

Issue 1222483002: Remove the ability to load ".sky" files (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/public/web/WebView.h ('k') | sky/shell/ui/engine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/web/WebViewImpl.cpp
diff --git a/sky/engine/web/WebViewImpl.cpp b/sky/engine/web/WebViewImpl.cpp
index 75e8929d0519126bcd6778d1cefd1bd865524f3a..861972b73a539f34160fc02d505341728cfe87bc 100644
--- a/sky/engine/web/WebViewImpl.cpp
+++ b/sky/engine/web/WebViewImpl.cpp
@@ -92,23 +92,9 @@ namespace blink {
// WebView ----------------------------------------------------------------
-bool WebView::shouldUseWebView(const GURL& url)
-{
- std::string filename = url.ExtractFileName();
- int hashStart = filename.find('#');
- if (hashStart != -1)
- filename.resize(hashStart);
- int queryStart = filename.find('?');
- if (queryStart != -1)
- filename.resize(queryStart);
- // For now .dart indicates we should use SkyView. Eventually we'll
- // use SkyView for all urls regardless of file extension.
- return !EndsWith(filename, ".dart", false)
- && !EndsWith(filename, ".snapshot", false);
-}
-
WebView* WebView::create(WebViewClient* client)
{
+ CRASH(); // WebView is deprecated. Please use SkyView.
Hixie 2015/06/30 21:45:03 I'm assuming deleting WebView itself is the next s
// Pass the WebViewImpl's self-reference to the caller.
return WebViewImpl::create(client);
}
« no previous file with comments | « sky/engine/public/web/WebView.h ('k') | sky/shell/ui/engine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698