Issue 12224137: Centralize logic for calculating (minimum) size of SPDY frames, by type, in SpdyFramer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12224137: Centralize logic for calculating (minimum) size of SPDY frames, by type, in SpdyFramer. (Closed)

Created:
7 years, 10 months ago by akalin

Modified:
7 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Centralize logic for calculating (minimum) size of SPDY frames, by type, in SpdyFramer. This will also help when deploying SPDY wire format changes, such as those upcoming in SPDY 4. This lands server change 41941878. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182283

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -163 lines)			Patch
M	net/spdy/spdy_framer.h	View	2 chunks	+13 lines, -4 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	24 chunks	+115 lines, -118 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	2 chunks	+14 lines, -41 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages