Centralize logic for calculating (minimum) size of SPDY frames, by type, in SpdyFramer.

net/spdy/spdy_framer_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <iostream>
 #include <limits>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 3002 matching lines @@
   SpdyControlFrame control_frame(&garbage_frame[0], false);
   control_frame.set_version(spdy_version_);
   TestSpdyVisitor visitor(spdy_version_);
   visitor.use_compression_ = false;
   visitor.SimulateInFramer(
       reinterpret_cast<unsigned char*>(control_frame.data()),
       sizeof(garbage_frame));
   EXPECT_EQ(1, visitor.error_count_);
 }
 
+TEST_P(SpdyFramerTest, SizesTest) {
+  SpdyFramer framer(spdy_version_);
+  EXPECT_EQ(8u, framer.GetControlFrameMinimumSize());
+  EXPECT_EQ(18u, framer.GetSynStreamMinimumSize());
+  EXPECT_EQ(IsSpdy2() ? 14u : 12u, framer.GetSynReplyMinimumSize());
+  EXPECT_EQ(16u, framer.GetRstStreamSize());
+  EXPECT_EQ(12u, framer.GetSettingsMinimumSize());
+  EXPECT_EQ(12u, framer.GetPingSize());
+  EXPECT_EQ(IsSpdy2() ? 12u : 16u, framer.GetGoAwaySize());
+  EXPECT_EQ(IsSpdy2() ? 14u : 12u, framer.GetHeadersMinimumSize());
+  EXPECT_EQ(16u, framer.GetWindowUpdateSize());
+  EXPECT_EQ(10u, framer.GetCredentialMinimumSize());
+}
+
 TEST_P(SpdyFramerTest, StateToStringTest) {
   EXPECT_STREQ("ERROR",
                SpdyFramer::StateToString(SpdyFramer::SPDY_ERROR));
   EXPECT_STREQ("DONE",
                SpdyFramer::StateToString(SpdyFramer::SPDY_DONE));
   EXPECT_STREQ("AUTO_RESET",
                SpdyFramer::StateToString(SpdyFramer::SPDY_AUTO_RESET));
   EXPECT_STREQ("RESET",
                SpdyFramer::StateToString(SpdyFramer::SPDY_RESET));
   EXPECT_STREQ("READING_COMMON_HEADER",
@@ skipping 95 matching lines @@
   EXPECT_STREQ("HEADERS",
                SpdyFramer::ControlTypeToString(HEADERS));
   EXPECT_STREQ("WINDOW_UPDATE",
                SpdyFramer::ControlTypeToString(WINDOW_UPDATE));
   EXPECT_STREQ("CREDENTIAL",
                SpdyFramer::ControlTypeToString(CREDENTIAL));
   EXPECT_STREQ("UNKNOWN_CONTROL_TYPE",
                SpdyFramer::ControlTypeToString(NUM_CONTROL_FRAME_TYPES));
 }
 
-TEST_P(SpdyFramerTest, GetMinimumControlFrameSizeTest) {
-  EXPECT_EQ(SpdySynStreamControlFrame::size(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   SYN_STREAM));
-  EXPECT_EQ(SpdySynReplyControlFrame::size(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   SYN_REPLY));
-  EXPECT_EQ(SpdyRstStreamControlFrame::size(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   RST_STREAM));
-  EXPECT_EQ(SpdySettingsControlFrame::size(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   SETTINGS));
-  EXPECT_EQ(SpdyFrame::kHeaderSize,
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   NOOP));
-  EXPECT_EQ(SpdyPingControlFrame::size(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   PING));
-  size_t goaway_size = SpdyGoAwayControlFrame::size();
-  if (IsSpdy2()) {
-    // SPDY 2 GOAWAY is smaller by 32 bits.
-    goaway_size -= 4;
-  }
-  EXPECT_EQ(goaway_size,
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   GOAWAY));
-  EXPECT_EQ(SpdyHeadersControlFrame::size(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   HEADERS));
-  EXPECT_EQ(SpdyWindowUpdateControlFrame::size(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   WINDOW_UPDATE));
-  EXPECT_EQ(SpdyCredentialControlFrame::size(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   CREDENTIAL));
-  EXPECT_EQ(numeric_limits<size_t>::max(),
-            SpdyFramer::GetMinimumControlFrameSize(spdy_version_,
-                                                   NUM_CONTROL_FRAME_TYPES));
-}
-
 TEST_P(SpdyFramerTest, CatchProbableHttpResponse) {
   {
     testing::StrictMock<test::MockVisitor> visitor;
     SpdyFramer framer(spdy_version_);
     framer.set_visitor(&visitor);
 
     EXPECT_CALL(visitor, OnError(_));
     framer.ProcessInput("HTTP/1.1", 8);
     EXPECT_TRUE(framer.probable_http_response());
     EXPECT_EQ(SpdyFramer::SPDY_ERROR, framer.state());
@@ skipping 384 matching lines @@
   const uint32 kWireFormat = htonl(IsSpdy2() ? 0x04030201 : 0x01020304);
 
   SettingsFlagsAndId id_and_flags =
       SettingsFlagsAndId::FromWireFormat(spdy_version_, kWireFormat);
   EXPECT_EQ(kId, id_and_flags.id());
   EXPECT_EQ(kFlags, id_and_flags.flags());
   EXPECT_EQ(kWireFormat, id_and_flags.GetWireFormat(spdy_version_));
 }
 
 }  // namespace net