Issue 12224111: [Telemetry] Add an --extra-wpr-args flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12224111: [Telemetry] Add an --extra-wpr-args flag. (Closed)

Created:
7 years, 10 months ago by tonyg

Modified:
7 years, 10 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, abarth-chromium, eseidel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Add an --extra-wpr-args flag. This is useful for running telemetry under simulated bandwidth conditions. For example, to run with DSL speed, pass: --extra-wpr-args="--shaping_type=proxy --net=dsl" BUG=None TEST=tools/perf/run_multipage_benchmarks --extra-wpr-args="--shaping_type=proxy --net=dsl" --browser=system loading_benchmark tools/perf/page_sets/top_25.json NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181815

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	tools/telemetry/telemetry/browser_options.py	View		3 chunks	+10 lines, -0 lines	0 comments	Download
	M	tools/telemetry/telemetry/wpr_server.py	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nduca

lgtm https://codereview.chromium.org/12224111/diff/1/tools/telemetry/telemetry/wpr_server.py File tools/telemetry/telemetry/wpr_server.py (right): https://codereview.chromium.org/12224111/diff/1/tools/telemetry/telemetry/wpr_server.py#newcode41 tools/telemetry/telemetry/wpr_server.py:41: if browser_backend.options.extra_wpr_args: no need for the if check, ...

7 years, 10 months ago (2013-02-12 01:41:27 UTC) #2

tonyg

7 years, 10 months ago (2013-02-12 01:44:34 UTC) #3

Message was sent while issue was closed.

On 2013/02/12 01:41:27, nduca wrote:
> lgtm
> 
>
https://codereview.chromium.org/12224111/diff/1/tools/telemetry/telemetry/wpr...
> File tools/telemetry/telemetry/wpr_server.py (right):
> 
>
https://codereview.chromium.org/12224111/diff/1/tools/telemetry/telemetry/wpr...
> tools/telemetry/telemetry/wpr_server.py:41: if
> browser_backend.options.extra_wpr_args:
> no need for the if check, right?

Thanks. Fixed.

Expand Messages | Collapse Messages