Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: tools/telemetry/telemetry/browser_options.py

Issue 12224111: [Telemetry] Add an --extra-wpr-args flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/wpr_server.py » ('j') | tools/telemetry/telemetry/wpr_server.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/browser_options.py
diff --git a/tools/telemetry/telemetry/browser_options.py b/tools/telemetry/telemetry/browser_options.py
index a174e13d5ad2eb98e66b461b2f9e755b294afbd2..631499c83e5dcc4d461edbbf544f5d91615600ee 100644
--- a/tools/telemetry/telemetry/browser_options.py
+++ b/tools/telemetry/telemetry/browser_options.py
@@ -24,6 +24,7 @@ class BrowserOptions(optparse.Values):
self.dont_override_profile = False
self.extra_browser_args = []
+ self.extra_wpr_args = []
self.show_stdout = False
self.cros_remote = None
@@ -86,6 +87,10 @@ class BrowserOptions(optparse.Values):
group.add_option('--extra-browser-args',
dest='extra_browser_args_as_string',
help='Additional arguments to pass to the browser when it starts')
+ group.add_option('--extra-wpr-args',
+ dest='extra_wpr_args_as_string',
+ help=('Additional arguments to pass to Web Page Replay. '
+ 'See third_party/webpagereplay/replay.py for usage.'))
group.add_option('--show-stdout',
action='store_true',
help='When possible, will display the stdout of the process')
@@ -151,6 +156,11 @@ class BrowserOptions(optparse.Values):
self.extra_browser_args_as_string) # pylint: disable=E1101
self.extra_browser_args.extend(tmp)
delattr(self, 'extra_browser_args_as_string')
+ if self.extra_wpr_args_as_string: # pylint: disable=E1101
+ tmp = shlex.split(
+ self.extra_wpr_args_as_string) # pylint: disable=E1101
+ self.extra_wpr_args.extend(tmp)
+ delattr(self, 'extra_wpr_args_as_string')
return ret
parser.parse_args = ParseArgs
return parser
« no previous file with comments | « no previous file | tools/telemetry/telemetry/wpr_server.py » ('j') | tools/telemetry/telemetry/wpr_server.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698