Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 12224107: Issue 8132. Suppress INFO problems in SDK. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
index cb153236ca96db7c2822d478bd91b711ecdcf5c3..15ee2bb2ef7b8ade391dc61c1491f9dcdf414227 100644
--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
@@ -288,10 +288,13 @@ public class TypeAnalyzer implements DartCompilationPhase {
}
private void onError(SourceInfo errorTarget, ErrorCode errorCode, Object... arguments) {
- if (suppressSdkWarnings && errorCode.getErrorSeverity() == ErrorSeverity.WARNING) {
- Source source = errorTarget.getSource();
- if (source != null && PackageLibraryManager.isDartUri(source.getUri())) {
- return;
+ if (suppressSdkWarnings) {
+ ErrorSeverity errorSeverity = errorCode.getErrorSeverity();
+ if (errorSeverity == ErrorSeverity.WARNING || errorSeverity == ErrorSeverity.INFO) {
+ Source source = errorTarget.getSource();
+ if (source != null && PackageLibraryManager.isDartUri(source.getUri())) {
+ return;
+ }
}
}
context.onError(new DartCompilationError(errorTarget, errorCode, arguments));
« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698