Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9632)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

Issue 12224107: Issue 8132. Suppress INFO problems in SDK. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
index 78897322e3e6172a0067500572f71fdad6397826..c1522c3a7a09305d0fc3dbf31933b37f8e2b5712 100644
--- a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
+++ b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
@@ -361,10 +361,13 @@ public class ResolutionContext implements ResolutionErrorListener {
}
public void onError(SourceInfo sourceInfo, ErrorCode errorCode, Object... arguments) {
- if (suppressSdkWarnings && errorCode.getErrorSeverity() == ErrorSeverity.WARNING) {
- Source source = sourceInfo.getSource();
- if (source != null && PackageLibraryManager.isDartUri(source.getUri())) {
- return;
+ if (suppressSdkWarnings) {
+ ErrorSeverity errorSeverity = errorCode.getErrorSeverity();
+ if (errorSeverity == ErrorSeverity.WARNING || errorSeverity == ErrorSeverity.INFO) {
+ Source source = sourceInfo.getSource();
+ if (source != null && PackageLibraryManager.isDartUri(source.getUri())) {
+ return;
+ }
}
}
context.onError(new DartCompilationError(sourceInfo, errorCode, arguments));
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698