Converting XHR from onLoad to onReadyStateChange

tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate

Index: tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate b/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate
index 078d873b230c53637867d92323a520d0ae3bedda..8034447dfd326b13c440a38ea958042607c85a6e 100644
--- a/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate
+++ b/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate
@@ -94,12 +94,14 @@ $(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
       xhr.onProgress.listen(onProgress);
     }
 
-    xhr.onLoad.listen((e) {
-      if (xhr.status >= 200 && xhr.status < 300 ||
-          xhr.status == 304 ) {
-        completer.complete(xhr);
-      } else {
-        completer.completeError(e);
+    xhr.onReadyStateChange.listen((e) {
+      if (xhr.readyState == HttpRequest.DONE) {
+        if (xhr.status >= 200 && xhr.status < 300 ||
+            xhr.status == 304 ) {

[Emily Fortuna, 2013/02/07 20:53:44]

This doesn't fix the problem described in dartbug.com/8401. What you should do
instead is run this branch if the status is also 0 (you can check if the request
is for a file URL specifically). The problem is status will be 0 for a local
file, regardless of whether or not it is actually "found"! So, completing as
opposed to completeError in that one case could be slightly misleading. That's
why I didn't have an actual error condition in the previous version of this
code. I think the flow described though is probably the least strange for most
cases.

+          completer.complete(xhr);
+        } else {
+          completer.completeError(e);
+        }
       }
     });