sdk/lib/html/dartium/html_dartium.dart - Issue 12224055: Converting XHR from onLoad to onReadyStateChange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 12224055: Converting XHR from onLoad to onReadyStateChange (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index b5e82af86a71bcc2b997884742fd66c6ae5d288c..50f679db9b38f03090c607a8279afa3d9126afbb 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -13736,12 +13736,14 @@ class HttpRequest extends EventTarget {

xhr.onProgress.listen(onProgress);

}

- xhr.onLoad.listen((e) {

- if (xhr.status >= 200 && xhr.status < 300 ||

- xhr.status == 304 ) {

- completer.complete(xhr);

- } else {

- completer.completeError(e);

+ xhr.onReadyStateChange.listen((e) {

+ if (xhr.readyState == HttpRequest.DONE) {

+ if (xhr.status >= 200 && xhr.status < 300 ||

+ xhr.status == 304 ) {

+ completer.complete(xhr);

+ } else {

+ completer.completeError(e);

+ }

}

});