Updated contains and isEmpty matches to use iterables.

Updated contains and isEmpty matches to use iterables.
Added two tests for iterables.

Added missing tests for StateErrors matchers.


BUG=http://dartbug.com/8159

[butlermatt, 2013-02-07 15:30:28]

https://codereview.chromium.org/12224053/diff/1/pkg/unittest/lib/src/core_mat...
File pkg/unittest/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/12224053/diff/1/pkg/unittest/lib/src/core_mat...
pkg/unittest/lib/src/core_matchers.dart:594: return item.contains(_expected);
I changed this to contains(), to allow Iterables to define their own contains
functions which may not do a specific one to one comparison of elements.

[gram, 2013-02-07 17:35:23]

lgtm Thanks very much. Just please fix the comment typo (not yours, but it may
as well be fixed in this CL).

https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
File pkg/unittest/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
pkg/unittest/lib/src/core_matchers.dart:576: * for [Map]s is means the map has
the key, and for [Iterable]s
While you're at it can you correct the comment? "is means" => "it means"

[butlermatt, 2013-02-07 17:50:15]

https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
File pkg/unittest/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
pkg/unittest/lib/src/core_matchers.dart:576: * for [Map]s is means the map has
the key, and for [Iterable]s
On 2013/02/07 17:35:23, gram wrote:
> While you're at it can you correct the comment? "is means" => "it means"

Done.

[gram, 2013-02-07 21:44:08]

On 2013/02/07 17:50:15, butlermatt wrote:
>
https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
> File pkg/unittest/lib/src/core_matchers.dart (right):
> 
>
https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
> pkg/unittest/lib/src/core_matchers.dart:576: * for [Map]s is means the map has
> the key, and for [Iterable]s
> On 2013/02/07 17:35:23, gram wrote:
> > While you're at it can you correct the comment? "is means" => "it means"
> 
> Done.

Thanks. Can you commit or do you need me to?

[butlermatt, 2013-02-07 21:48:04]

On 2013/02/07 21:44:08, gram wrote:
> On 2013/02/07 17:50:15, butlermatt wrote:
> >
>
https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
> > File pkg/unittest/lib/src/core_matchers.dart (right):
> > 
> >
>
https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
> > pkg/unittest/lib/src/core_matchers.dart:576: * for [Map]s is means the map
has
> > the key, and for [Iterable]s
> > On 2013/02/07 17:35:23, gram wrote:
> > > While you're at it can you correct the comment? "is means" => "it means"
> > 
> > Done.
> 
> Thanks. Can you commit or do you need me to?

I can not commit, so will need you to please. Thanks, Matt

[butlermatt, 2013-02-07 21:49:17]

On 2013/02/07 21:48:04, butlermatt wrote:
> On 2013/02/07 21:44:08, gram wrote:
> > On 2013/02/07 17:50:15, butlermatt wrote:
> > >
> >
>
https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
> > > File pkg/unittest/lib/src/core_matchers.dart (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/12224053/diff/3001/pkg/unittest/lib/src/core_...
> > > pkg/unittest/lib/src/core_matchers.dart:576: * for [Map]s is means the map
> has
> > > the key, and for [Iterable]s
> > > On 2013/02/07 17:35:23, gram wrote:
> > > > While you're at it can you correct the comment? "is means" => "it means"
> > > 
> > > Done.
> > 
> > Thanks. Can you commit or do you need me to?
> 

I can not commit, so will need you to please. Thanks, Matt