chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h - Issue 12224052: Alternate NTP: Fix bug where shadow is not removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

Issue 12224052: Alternate NTP: Fix bug where shadow is not removed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix tests Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/instant_preview_controller_mac.mm ('k') | chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

diff --git a/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h b/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

index a40053b7f03b8d3d38d6734b120a49992a0dec3d..8e666437ea6488a705301f65b4cdfed8da007122 100644

--- a/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

+++ b/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

@@ -77,14 +77,12 @@ class WebContents;

windowController:(BrowserWindowController*)windowController;

// Sets the current preview and installs its WebContentsView into the view

-// hierarchy. Hides the active view. |preview| must not be NULL.

-- (void)showPreview:(content::WebContents*)preview

- height:(CGFloat)height

- heightUnits:(InstantSizeUnits)heightUnits

- drawDropShadow:(BOOL)drawDropShadow;

-// Closes the current preview and shows the active view.

-- (void)hidePreview;

+// hierarchy. Hides the active view. If |preview| is NULL then closes the

+// current preview and shows the active view.

+- (void)setPreview:(content::WebContents*)preview

+ height:(CGFloat)height

+ heightUnits:(InstantSizeUnits)heightUnits

+ drawDropShadow:(BOOL)drawDropShadow;

// Called when a tab with |contents| is activated, so that we can check to see

// if it's the preview being activated (and adjust internal state accordingly).